On Fri, Feb 19, 2021 at 5:33 PM Gabe Montero <gmontero(a)redhat.com&gt; wrote: > So it's been about a week and from the PR activity I've seen, folks seem > to have adopted the new PR template and release note process just fine. > > Of course, folks chime in here if I've missed anything. > > That said, I'd like to offer a suggestion: > > If folks add kind label(s) to their PR that categories the nature of the > change (feature, bug, api-change, etc.), then the updates to the release > github action I'm working on can look for those labels to facilitate the > sorting of the release notes. > > I'll see if there is a way to enforce this use of a kind label on PRs, > though I'm not confident, > Turns out I should have had more confidence. Prow provides exactly what we need to enforce the use of kind labels of PRs: https://github.com/kubernetes/test-infra/blob/master/label_sync/labels.md... I'll give it a day or two, but unless there are objections noted here or in slack (I'll be posting there momentarily) I will be enabling this plugin for shipwright-io/build thanks, gabe > and if there is not a direct "Fixes ..." correlation made to a github > issue that might be relevant (though event that could be a stretch), I > think we might still have some manual categorization of release notes > required when we cut a new release. > > thanks, > gabe > _______________________________________________ shipwright-dev mailing list -- shipwright-dev(a)lists.shipwright.io To unsubscribe send an email to shipwright-dev-leave(a)lists.shipwright.io

Thanks Everyone. I'll move on this today. A couple of minor follow ups: - +1 agree with you Enrique on the possible / probable need for manual intervention even after my automation lands, at least for a few iterations, if not long term, while we get some practical experience on how this works running out of github actions vs. running bash in my workspace - Sascha asked in slack if there was any interaction between the prow plugin for release notes and plugin for kind labels, i.e. you don't need a kind label if release-note-none is specified. I could find no evidence of that. But in the end, based on the tenor here, as well as my opinion, getting prescriptive on PR kind classification regardless is a good thing. So we'll move forward. On Wed, Feb 24, 2021 at 7:51 AM Enrique Encalada <encalada(a)de.ibm.com&gt; wrote: > Thanks Gabe. +1 on that. I think we might still need a manual > intervention before publishing a latest stable release, this is why the > automation will generate a draft release only. > > Regards, > Enrique E. Encalada > _______________________________________________ > shipwright-dev mailing list -- shipwright-dev(a)lists.shipwright.io > To unsubscribe send an email to shipwright-dev-leave(a)lists.shipwright.io >