----- Original message -----
From: Adam Kaplan <adam.kaplan@redhat.com>
To: Gabe Montero <gmontero@redhat.com>
Cc: shipwright-dev@lists.shipwright.io
Subject: [EXTERNAL] [shipwright-dev] Re: UPDATE: PRs and the prow 'release-note' plugin
Date: Wed, Feb 24, 2021 3:09 AM
 

+1 to enforcing `kind` labels on PRs. The PR template should also be updated to invoke the right `/kind` prow command.

 

On Mon, Feb 22, 2021 at 10:14 AM Gabe Montero <gmontero@redhat.com> wrote:

 

 

On Fri, Feb 19, 2021 at 5:33 PM Gabe Montero <gmontero@redhat.com> wrote:

So it's been about a week and from the PR activity I've seen, folks seem to have adopted the new PR template and release note process just fine.

 

Of course, folks chime in here if I've missed anything.

 

That said, I'd like to offer a suggestion:

 

If folks add kind label(s) to their PR that categories the nature of the change (feature, bug, api-change, etc.), then the updates to the release github action I'm working on can look for those labels to facilitate the sorting of the release notes.

 

I'll see if there is a way to enforce this use of a kind label on PRs, though I'm not confident,

 

Turns out I should have had more confidence.  Prow provides exactly what we need to enforce the use of kind labels of PRs:  https://github.com/kubernetes/test-infra/blob/master/label_sync/labels.md#needs-kind

 

I'll give it a day or two, but unless there are objections noted here or in slack (I'll be posting there momentarily) I will be enabling this plugin for shipwright-io/build

 

thanks,

gabe

 

and if there is not a direct "Fixes ..." correlation made to a github issue that might be relevant (though event that could be a stretch), I think we might still have some manual categorization of release notes required when we cut a new release.

 

thanks,

gabe

_______________________________________________
shipwright-dev mailing list -- shipwright-dev@lists.shipwright.io
To unsubscribe send an email to shipwright-dev-leave@lists.shipwright.io

--

Adam Kaplan

He/Him

Principal Software Engineer

Red Hat

100 E. Davie Street

adam.kaplan@redhat.com    T: 1-919-754-4843    

_______________________________________________
shipwright-dev mailing list -- shipwright-dev@lists.shipwright.io
To unsubscribe send an email to shipwright-dev-leave@lists.shipwright.io